Forward deopt node path #11832
Merged
Forward deopt node path #11832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c3065e8:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25983/ |
JLHwung
reviewed
Jul 15, 2020
| @@ -21,6 +21,25 @@ describe("evaluation", function () { | |||
| }); | |||
| } | |||
|
|
|||
| function addDeoptTest(code, type, expectedType) { | |||
There was a problem hiding this comment.
nit: Can you move these tests to packages/babel-traverse/test/evaluation.js?
JLHwung
approved these changes
Jul 15, 2020
JLHwung
added
the
PR: Polish 💅
|
Fixed |
|
Do you need anything from me before merging? |
|
@johanholmerin We have a two-approval policy on merging PR. ping @babel/core-team. |
hzoo
approved these changes
Aug 16, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when evaluating array values, object keys, and object properties, if a deopt is found, the location is discarded and the location in the array or the object will be used. I suggest this information is kept. It will make it easier to understand the cause of the deopt.