Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix innercomments #11697

Merged
merged 5 commits into from Jun 13, 2020
Merged

Fix innercomments #11697

merged 5 commits into from Jun 13, 2020

Conversation

shaodahong
Copy link
Contributor

@shaodahong shaodahong commented Jun 9, 2020

Q                       A
Fixed Issues? Fixes #11469
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 9, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23787/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 579394c:

Sandbox Source
dreamy-wu-135fz Configuration
new-bash-2wgc0 Configuration

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Can you fix up the failing tests in CI?

packages/babel-parser/src/parser/comments.js Outdated Show resolved Hide resolved
packages/babel-parser/src/parser/comments.js Outdated Show resolved Hide resolved
@kaicataldo kaicataldo added area: comments pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jun 9, 2020
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@existentialism existentialism merged commit e15a5c7 into babel:master Jun 13, 2020
@existentialism
Copy link
Member

@shaodahong thanks!

@shaodahong shaodahong deleted the fix-innercomments branch June 13, 2020 02:26
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: comments outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
6 participants