Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: output ascii only standalone minified bundle #11672

Merged
merged 1 commit into from Jun 4, 2020
Merged

chore: output ascii only standalone minified bundle #11672

merged 1 commit into from Jun 4, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jun 4, 2020 •
edited

Q                       A
Fixed Issues? The minified @babel/standalone build will throw syntax error on Safari.
Patch: Bug Fix? Yes
Tests Added + Pass? No, but I think we can introduced browser smoking test for @babel/standalone.
License MIT

Related: babel/website#2269

@JLHwung JLHwung added PR: Internal 🏠 A type of pull request used for our changelog categories area: upstream labels Jun 4, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23432/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e1945eb:

Sandbox Source
morning-frog-2ditg Configuration
youthful-feather-8mcrz Configuration

@JLHwung JLHwung merged commit 8a98ec9 into babel:master Jun 4, 2020
@JLHwung JLHwung deleted the fix-babel-standalone-min-safari branch June 4, 2020 18:10
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
area: upstream outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @existentialism @kaicataldo