Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add new plugin names to missing plugin helpers #11643

Merged
merged 1 commit into from May 29, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 29, 2020

Q                       A
License MIT

A small follow-up to both #11372 and #10962.

@JLHwung JLHwung added PR: Polish 💅 A type of pull request used for our changelog categories pkg: core labels May 29, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eb025df:

Sandbox Source
green-field-u083p Configuration
nifty-darkness-om47t Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23134/

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, simple enough to test in

codesandbox
import foo from "foo.json" with type: "json";

class C {
  #brand;
  static isC(obj) {
    return #brand in obj
  }
}
export default function (babel) {
  return {
    manipulateOptions(opts, parserOpts) {
      parserOpts.plugins.push(
        "classPrivateProperties", "privateIn", ["moduleAttributes", { version: "may-2020"}]
      );
    }
  };
}

@JLHwung JLHwung merged commit 6b7a6dc into babel:master May 29, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2020
@JLHwung JLHwung deleted the add-more-missing-plugin-helpers branch October 12, 2020 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: core PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants