Isolated exec tests #11531
Isolated exec tests #11531
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27204/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 57602a2:
|
This comment has been minimized.
This comment has been minimized.
|
Switching to the bundled |
The individual requires for each file were the part that was sooooo slow.
jridgewell
force-pushed
the
isolated-exec-tests
branch
from
43179d7
to
61aebfe
Compare
JLHwung
added
the
PR: Internal 🏠
| @@ -1,8 +1,8 @@ | |||
| var code = multiline([ | |||
There was a problem hiding this comment.
nit: Can we also remove multiline from packages/babel-helper-transform-fixture-test-runner/src/helpers.js? It is never exported from index.js.
There was a problem hiding this comment.
Not without a major bump. It's installed into the exec context, so it's available to tests. It's probably unused.
There was a problem hiding this comment.
If it's a concern around people using babel-helper-transform-fixture-test-runner as a dep I think we've never supported that as an API so it's fine (https://www.npmjs.com/package/@babel/helper-transform-fixture-test-runner). It's internal only essentially (we have no docs on it either), not that it's a good thing
github-actions
bot
added
the
outdated
Split from #11520, this run each
exec.jstest with a fresh global context to avoid pollution.