Add "allowArrayLike" support to the for-of transform #11266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: New Feature 🚀
nicolo-ribaudo
changed the title
nicolo-ribaudo
force-pushed
the
iterables-dx/for-of-no-symbol-allow-array
branch
from
d5b9ea3
to
fe088fe
Compare
nicolo-ribaudo
moved this from Ready for review
to allowArrayLike optoin
in Iterables DX
nicolo-ribaudo
force-pushed
the
iterables-dx/for-of-allowArrayLike
branch
from
77adb90
to
2811336
Compare
nicolo-ribaudo
moved this from allowArrayLike optoin
to Ready for review
in Iterables DX
nicolo-ribaudo
changed the title
nicolo-ribaudo
changed the base branch from
iterables-dx/for-of-no-symbol-allow-array
to
master
jridgewell
approved these changes
Mar 20, 2020
JLHwung
reviewed
Mar 21, 2020
| @@ -6,14 +6,20 @@ import transformWithoutHelper from "./no-helper-implementation"; | |||
| export default declare((api, options) => { | |||
| api.assertVersion(7); | |||
|
|
|||
| const { loose, assumeArray } = options; | |||
| const { loose, assumeArray, allowArrayLike } = options; | |||
There was a problem hiding this comment.
Might worthy to note that this option requires babel/core@7.9.0, otherwise it is an no-op.
kaicataldo
approved these changes
Apr 6, 2020
nicolo-ribaudo
force-pushed
the
iterables-dx/for-of-allowArrayLike
branch
from
2811336
to
2a06541
Compare
existentialism
approved these changes
Apr 15, 2020
nicolo-ribaudo
added
PR: Ready to be Merged
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabled, this option makes Babel treat array-like objects as if
they were iterables. This makes it possible to avoid a
Symbolpolyfill whenusing for-of on DOM lists, strings or
argumentsin browsers withoutSymbol.iteratorsupport.