Skip newlines around inline #__PURE__ annotations
#11133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Polish 💅
nicolo-ribaudo
commented
Feb 12, 2020
| this._printComment( | ||
| comments[0], | ||
| // Keep newlines if the comment marks a standalone call | ||
| this._buf.hasContent() && !this.endsWith("\n"), |
There was a problem hiding this comment.
This is for cases like https://github.com/babel/babel/blob/master/packages/babel-plugin-proposal-async-generator-functions/test/fixtures/async-generators/expression/output.js#L1, where I think that we should keep the \n.
existentialism
approved these changes
Feb 12, 2020
JLHwung
approved these changes
Feb 13, 2020
rajasekarm
pushed a commit
to rajasekarm/babel
that referenced
this pull request
Feb 17, 2020
* Skip newlines around #__PURE__ annotations * Update tests
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly to improve the output readability, since the unindented newlines looked really bad.
I special-cased
/*#__PURE__*/annotations because I think that we should preserve the old behavior for normal comments.