From bc430c7bf6480ec29aa56e039c9771e52ab6f4b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hu=C3=A1ng=20J=C3=B9nli=C3=A0ng?= Date: Thu, 26 Dec 2019 15:19:16 -0500 Subject: [PATCH 1/2] fix: promise.any requires global.AggregateError --- .../src/polyfills/corejs3/built-in-definitions.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/babel-preset-env/src/polyfills/corejs3/built-in-definitions.js b/packages/babel-preset-env/src/polyfills/corejs3/built-in-definitions.js index f3de8ef83733..d1b900a44b43 100644 --- a/packages/babel-preset-env/src/polyfills/corejs3/built-in-definitions.js +++ b/packages/babel-preset-env/src/polyfills/corejs3/built-in-definitions.js @@ -57,6 +57,11 @@ const PromiseDependenciesWithIterators = [ ...CommonIterators, ]; +const PromiseAnyDependencies = [ + "esnext.aggregate-error", + ...PromiseDependenciesWithIterators, // includes aggregate-error dependencies +]; + const SymbolDependencies = [ "es.symbol", "es.symbol.description", @@ -358,7 +363,7 @@ export const StaticProperties: ObjectMap> = { "esnext.promise.all-settled", ...PromiseDependenciesWithIterators, ], - any: ["esnext.promise.any", ...PromiseDependenciesWithIterators], + any: ["esnext.promise.any", ...PromiseAnyDependencies], race: PromiseDependenciesWithIterators, try: ["esnext.promise.try", ...PromiseDependenciesWithIterators], }, From c6a3d961c48202b6c788aa9f1917c9fe18ceb433 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hu=C3=A1ng=20J=C3=B9nli=C3=A0ng?= Date: Thu, 26 Dec 2019 19:59:58 -0500 Subject: [PATCH 2/2] address review comments --- .../src/polyfills/corejs3/built-in-definitions.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/packages/babel-preset-env/src/polyfills/corejs3/built-in-definitions.js b/packages/babel-preset-env/src/polyfills/corejs3/built-in-definitions.js index d1b900a44b43..2ed1915d87c5 100644 --- a/packages/babel-preset-env/src/polyfills/corejs3/built-in-definitions.js +++ b/packages/babel-preset-env/src/polyfills/corejs3/built-in-definitions.js @@ -57,11 +57,6 @@ const PromiseDependenciesWithIterators = [ ...CommonIterators, ]; -const PromiseAnyDependencies = [ - "esnext.aggregate-error", - ...PromiseDependenciesWithIterators, // includes aggregate-error dependencies -]; - const SymbolDependencies = [ "es.symbol", "es.symbol.description", @@ -363,7 +358,11 @@ export const StaticProperties: ObjectMap> = { "esnext.promise.all-settled", ...PromiseDependenciesWithIterators, ], - any: ["esnext.promise.any", ...PromiseAnyDependencies], + any: [ + "esnext.promise.any", + "esnext.aggregate-error", + ...PromiseDependenciesWithIterators, + ], race: PromiseDependenciesWithIterators, try: ["esnext.promise.try", ...PromiseDependenciesWithIterators], },