Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Promise.any requires global.AggregateError #10930

Merged
merged 2 commits into from Dec 27, 2019

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 26, 2019

Q                       A
Fixed Issues? Fixes #10910
Patch: Bug Fix? Yes
Tests Added + Pass? Nope
License MIT

C.f. zloirock/core-js#737 (comment)

@JLHwung JLHwung added area: experimental PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: preset-env labels Dec 26, 2019
@@ -358,7 +363,7 @@ export const StaticProperties: ObjectMap<ObjectMap<string | string[]>> = {
"esnext.promise.all-settled",
...PromiseDependenciesWithIterators,
],
any: ["esnext.promise.any", ...PromiseDependenciesWithIterators],
any: ["esnext.promise.any", ...PromiseAnyDependencies],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it would be better just add esnext.aggregate-error to this line since at this moment it's used only here and I have no ideas wherePromiseAnyDependencies can be used in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do. I thought it was some unwritten code convention that almost every entry is written as [name, ...depedencies].

@JLHwung JLHwung merged commit e9dc74e into babel:master Dec 27, 2019
@JLHwung JLHwung deleted the fix-corejs-promise-any-dependencies branch December 27, 2019 01:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: experimental outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core-js definitions not fully injected with useBuiltIns: usage
4 participants