Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune makefile scripts #10781

Merged
merged 5 commits into from Dec 5, 2019
Merged

Tune makefile scripts #10781

merged 5 commits into from Dec 5, 2019

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 29, 2019

Q                       A
License MIT

In this PR we wrap node call into a yarn call so it can be future-proof on upcoming yarn 2 upgrade.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Nov 29, 2019
jestArgs="--coverage"

if [ -n "$CI" ]; then
jestArgs="${jestArgs} --maxWorkers=4 --ci"
fi

node_modules/.bin/jest $jestArgs
$node node_modules/.bin/jest $jestArgs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We leave jest to be relative path as we plan to unplug jest on yarn 2 so that it can work with --inspect-brk.

@@ -14,6 +14,9 @@ EMPTY :=
SPACE := $(EMPTY) $(EMPTY)
COMMA_SEPARATED_SOURCES = $(subst $(SPACE),$(COMMA),$(SOURCES))

YARN := yarn --silent
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will suppress the yarn foo v1.2.3 header printed by yarn. I think it is okay to use $(YARN) when we use it to invoke another node binaries, e.g. eslint/prettier.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants