Circumvent typeof transform for umd build template #10701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
jridgewell
approved these changes
Nov 13, 2019
|
@langi93 Is that related to this PR? |
|
It's a spam account. |
nicolo-ribaudo
approved these changes
Nov 13, 2019
This was referenced Dec 12, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we revise the umd module build template to avoid typeof transforms. It is not an ideal fix as ultimately we should hoist helper declaration to the program block if referenced by any nodes in the build template.
On the other hand we may skip polyfilling the
typeofcalls in build template as it is rare to assign a symbol to these global properties.This PR is a follow-up to #10477.