Babel should not silently remove unknown options after commander arguments #10698
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commander.js
is bumped to v4.0.1In this PR we bump
commander.js
to v4.0.1, which can throw on unknown options after arguments when an action handler is provided. To do so we register an empty action handler so that unknown options error can be thrown.Impact analysis of upgrading
commander.js
from 2.8 to 4.0Breaking changes from 2.0 to 3.0
Not related
Not related since we are not using custom event listeners
Not related since we don't have any option that has both
--no-
and--
prefixes.Breaking changes from 3.0 to 4.0
Not related since we are not using the command object in an action handler
It should be fine since we will drop Node 6 and 8 soon, too. If CI is good we may say it should work on Node 6 from now on.
Not related since I can't find any
.args.length
usage in our codebase.