Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove accessibility of constructor #10658

Merged
merged 1 commit into from Nov 5, 2019

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 5, 2019

Q                       A
Fixed Issues? Fixes #10644
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

The fix is complete as a constructor node may not have optional and abstract modifier.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Nov 5, 2019
@buildsize
Copy link

buildsize bot commented Nov 5, 2019

File name Previous Size New Size Change
babel-preset-env.js 2.78 MB 2.78 MB 0 bytes (0%)
babel-preset-env.min.js 1.67 MB 1.67 MB 0 bytes (0%)
babel.js 2.96 MB 2.96 MB 67 bytes (0%)
babel.min.js 1.63 MB 1.63 MB 50 bytes (0%)
test262.tap 4.84 MB [deleted]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] babel-preset-typescript with babel-loader failed to parse private constructor
3 participants