Fix some incorrect typeof parsing in flow #10657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
added
PR: Bug Fix 🐛
JLHwung
approved these changes
Nov 6, 2019
| @@ -1134,12 +1151,12 @@ export default (superClass: Class<Parser>): Class<Parser> => | |||
| ): N.FlowQualifiedTypeIdentifier { | |||
| startPos = startPos || this.state.start; | |||
| startLoc = startLoc || this.state.startLoc; | |||
| let node = id || this.parseIdentifier(); | |||
| let node = id || this.parseIdentifier(true); | |||
There was a problem hiding this comment.
I think we should also replace by flowParseRestrictedIdentifier here because
interface I extends bool.member {}
will throw unexpected reserved type, though the error message is not optimal.
There was a problem hiding this comment.
Updated with tests!
existentialism
force-pushed
the
flow-default
branch
from
794d723
to
b685ef8
Compare
nicolo-ribaudo
approved these changes
Nov 12, 2019
| @@ -22,12 +22,15 @@ import { | |||
| SCOPE_OTHER, | |||
| } from "../util/scopeflags"; | |||
|
|
|||
| const reservedTypes = [ | |||
| const reservedTypes = new Set([ | |||
| "_", | |||
There was a problem hiding this comment.
I wish there was something like https://eslint.org/docs/rules/sort-keys for arrays
| @@ -0,0 +1,2 @@ | |||
| // @flow | |||
| const x: typeof type.interface = "hi"; | |||
There was a problem hiding this comment.
I would report this as bug to the flow team, given that type.interface is valid in JS 🤔
| @@ -0,0 +1,15 @@ | |||
| // @flow | |||
| const a: typeof default = "hi"; | |||
There was a problem hiding this comment.
This also seem like a flow bug, since default is not a valid variable name.
This was referenced Dec 12, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went and matched parsing behavior in flow parser v0.111.1, and the error message in cases where user wasn't technically overwriting.