Create @babel/plugin-syntax-top-level-await #10573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: New Feature 🚀
JLHwung
reviewed
Oct 21, 2019
| @@ -0,0 +1,3 @@ | |||
| node_modules | |||
| *.log | |||
| src | |||
There was a problem hiding this comment.
nit: should also ignore test, to be future-proof.
There was a problem hiding this comment.
I just copy-pasted this file from somewhere else in the repo; we should fix many of them.
JLHwung
approved these changes
Oct 21, 2019
existentialism
approved these changes
Oct 24, 2019
nicolo-ribaudo
added
the
PR: Ready to be Merged
nicolo-ribaudo
force-pushed
the
plugin-syntax-tla
branch
from
ea87fd4
to
e8fe116
Compare
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @hzoo in #10449 (comment), I added a
callerflag for TLA used bypreset-env, because both webpack and rollup already have experimental support for top level await.The tests are currently failing because this PR depends on #10449