Use make -j for parallel build
#10506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
JLHwung
force-pushed
the
parallel-build
branch
from
aeb57f5
to
e0e0b76
Compare
nicolo-ribaudo
approved these changes
Oct 1, 2019
.travis.yml
Outdated
| # We test the latest version on circleci | ||
| - node_js: "11" | ||
| - node_js: "10" | ||
| # Move `windows` build to be the fourth since it is slow |
There was a problem hiding this comment.
Also node 6 is slow. What do you think about this order?
- Lint
- Node 11 (fast, for quick feedback)
- Windows
- Node 6
- Node 8
- Node 10
- Flow
- Test262
There was a problem hiding this comment.
We can definitely give it a try. As long as Windows or Node 6 is not the last I think they would not make significant difference.
How many concurrent jobs do we have on circle ci? If we have two concurrent jobs we can move windows testing to circle ci.
existentialism
approved these changes
Oct 2, 2019
Merged
This was referenced Oct 22, 2019
This was referenced Nov 12, 2019
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces general improvements to current build scripts. The following jobs have seen significant time reduce
The following improvements are implemented:
gulp build-babel-typesformake lint, so thatlintdoes not have to build all babel packages.merge-streamby refactoringbuildBabelmake code-quality: an umbrella rule (with parallelism) ofmake lint && make flow.make build-standaloneandmake build-preset-env-standaloneinlint,parser-flow-testandparser-test262-testjobs.make bootstrap-onlyandmake bootstrap-flowas they requests different services and writes to different destinations.make bootstrap-onlyandmake bootstrap-test262for the same reason abovemake build-standaloneandmake build-preset-env-standaloneas they writes to different destinations.makecall to$(MAKE)variableNote that now the lint job will run first since it is less expensive than unit testing.
Other thoughts: I did a rough measure on travis: it will take 2 min for machine setup + yarn install + lerna bootstrap, even with yarn cache. Could we merge
lint,parser-flow-testandparser-test262-testinto one job so that we can remove machine setup overhead?