Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optional chaining and nullish coalescing plugins #10494

Merged
merged 2 commits into from Sep 24, 2019

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

They are both stage 3, and they are used in a few PRs (e.g. #10491, #10357)

@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 24, 2019
@nicolo-ribaudo nicolo-ribaudo changed the title Enable optional chaining and nullish coaleshing plugins Enable optional chaining and nullish coalescing plugins Sep 24, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11694/

1 similar comment
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11694/

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should we add these to preset-env shippedProposals eventually? Not sure how many people are using that anyway though

@nicolo-ribaudo
Copy link
Member Author

Well, they aren't shipped anywhere yet 😛

https://kangax.github.io/compat-table/esnext/#test-optional_chaining_operator_(?.)

@nicolo-ribaudo nicolo-ribaudo merged commit eaa1474 into babel:master Sep 24, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the optional-chaining-enable branch September 24, 2019 21:11
@mrtnzlml
Copy link

@nicolo-ribaudo It's also a good idea to enable this lint rule to make sure it's used correctly: unnecessary-optional-chain

Just a small tip 🍻 :)

@jsg2021
Copy link

jsg2021 commented Nov 8, 2019

Nice! Should we add these to preset-env shippedProposals eventually? Not sure how many people are using that anyway though

@hzoo I use shippedProposals 😉

@nicolo-ribaudo
Copy link
Member Author

Spoiler: given that we release a new minor about every 2 months, probably shippedProposals won't be the correct place for at least one of them 😉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants