New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[parser] Disallow numeric separators in legacy octal like integers #10493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11702/ |
nicolo-ribaudo
added
pkg: parser
PR: Spec Compliance 👓
A type of pull request used for our changelog categories
Spec: Numeric Separator
labels
Sep 24, 2019
packages/babel-parser/test/fixtures/experimental/numeric-separator/invalid-lol/input.js
Outdated
Show resolved
Hide resolved
nicolo-ribaudo
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks to you! Super glad to contribute :) |
JLHwung
approved these changes
Sep 24, 2019
This was referenced Oct 22, 2019
This was referenced Nov 12, 2019
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
lock
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Dec 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
pkg: parser
PR: Spec Compliance 👓
A type of pull request used for our changelog categories
Spec: Numeric Separator
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The follow code should throw an error if the numeric separator plugin is enabled:
Input Code
00_0
Expected behavior/code
It should throw Invalid
Invalid numeric separator after leading 0
error.The Legacy Octal Like Decimal is defined as:
Reference