[parser] Report escapes in kws only if they won't be used as identifiers #10455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can do it by tokenizing escaped keywords as normal identifiers, so that they won't be accidentally used as real keywords.
nicolo-ribaudo
added
PR: Spec Compliance 👓
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11591/ |
1 similar comment
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11591/ |
JLHwung
reviewed
Sep 17, 2019
packages/babel-parser/test/fixtures/core/escape-keyword/invalid/options.json
Show resolved
Hide resolved
JLHwung
approved these changes
Sep 17, 2019
existentialism
approved these changes
Sep 17, 2019
This was referenced Oct 2, 2019
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Oct 22, 2019
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Oct 22, 2019
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Oct 22, 2019
nicolo-ribaudo
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Nov 5, 2019
nicolo-ribaudo
added a commit
that referenced
this pull request
Nov 5, 2019
* Add error recovery support to @babel/parser * Update @babel/parser tests to always recover from errors * Update this.raise usage in @babel/parser: - expression.js - lval.js - statement.js - estree.js - flow.js - jsx/index.js - tokenizer/index.js * Update @babel/parser fixtures with recovered errors * Fix tests out of @babel/parser * Do not use try/catch for control flow * Update invalid fixtures * Do not report invalid lhs in toAssignable * Do not validate function id multiple times * Dedupe reserved await errors * Remove duplicate errors about strict reserved bindings * Remove duplicated error about yield/await inside params * Don't error twice for methods in object patterns * Don't report invalid super() twice * Remove dup error about reserved param for expr arrows * Remove double escapes in migrated tests * Dedupe errors about invalid escapes in identifiers * Remove duplicated error about decorated constructor * Remove duplicated error about spread in flow class * Don't throw for invalid super usage * Don't fail for object decorators with stage 2 * Fix flow inexact type errors * Fix flow * Fix errors about escapes in keywords (ref: #10455) * Update after rebase * Fix todo * Remove duplicated error when using += for defaults * Remove unnecessary throw * Nit: use ??
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can do it by tokenizing escaped keywords as normal identifiers, so that they won't
be accidentally used as real keywords.