Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove tryResolve dependency #10428

Merged
merged 1 commit into from Sep 11, 2019

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 10, 2019

Q                       A
Fixed Issues? remove try-resolve dependency from fixtures-runner.
License MIT

I couldn't even find the repository of try-resolve but looking to https://unpkg.com/browse/try-resolve@1.0.1/index.js it is straightforward and we don't need the extra resolve.relative method.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 10, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11545/

1 similar comment
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11545/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the magic of the npm ecosystem: 5-lines modules 🎅

@nicolo-ribaudo nicolo-ribaudo merged commit 1b352ca into babel:master Sep 11, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants