Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add lint-ts rule #10427

Merged
merged 1 commit into from Sep 11, 2019
Merged

chore: add lint-ts rule #10427

merged 1 commit into from Sep 11, 2019

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 10, 2019

Q                       A
Tests Added + Pass? Yes
License MIT

Add lint-ts to lint rule. Basically it runs typescript compiler on generated babel types index.d.ts and reports any errors. This should prevent #10403 happens again.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 10, 2019
@nicolo-ribaudo
Copy link
Member

Generated flow types are already checked by make flow, right?

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11544/

@JLHwung
Copy link
Contributor Author

JLHwung commented Sep 10, 2019

Generated flow types are already checked by make flow, right?

Yes. make flow will check the flow types in the project scope. But typescript files are only limited to babel-types and it is auto-generated, so I don't think it suffices to add make typescript unless we have typescript in our codebase.

@nicolo-ribaudo nicolo-ribaudo merged commit 0ee2c42 into babel:master Sep 11, 2019
@JLHwung JLHwung deleted the add-lint-ts branch September 11, 2019 23:22
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants