Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't polyfill when evaluation is not confident #10397

Merged
merged 1 commit into from Sep 5, 2019

Conversation

rhyzx
Copy link
Contributor

@rhyzx rhyzx commented Sep 5, 2019

Q                       A
Fixed Issues? N/A
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

usage/corejs2 will still polyfill if evaluation of property name is not confident,
while corejs3 does not have this bug.

Input:

Object[values]();

Before output:

import "core-js/modules/es6.object.to-string";
import "core-js/modules/es7.object.values";
Object[values]();

After output:

Object[values]();

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11469/

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: preset-env labels Sep 5, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit 5c859b1 into babel:master Sep 5, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants