Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace es.string.reverse with es.array.reverse #10284

Merged
merged 1 commit into from Aug 1, 2019

Conversation

epicfaace
Copy link
Contributor

Q                       A
Fixed Issues? Fixes #10076
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? N
License MIT

Replace es.string.reverse with es.array.reverse for corejs@3 definitions. You can see that only es.array.reverse exists in corejs@3.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11267/

@JLHwung JLHwung added pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jul 31, 2019
@nicolo-ribaudo
Copy link
Member

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 6672763 into babel:master Aug 1, 2019
@epicfaace epicfaace deleted the reverse branch August 1, 2019 15:24
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no es.string.reverse in babel-preset-env/corejs3/built-in-definitions
4 participants