Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows to travis #10249

Merged
merged 20 commits into from Sep 26, 2019
Merged

Add windows to travis #10249

merged 20 commits into from Sep 26, 2019

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 22, 2019

Q                       A
Fixed Issues? Fixes #10254, fixes #10209, fixes #10252
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR is collaborated by @nicolo-ribaudo and @JLHwung.
In this PR, we

  • revamped Makefile to make it buildable on windows
  • added a new task option os to babel-helper-fixtures, which specifies the operating system that the test will run on
  • normalized preset-env filename log to make sure they can generate consistent test fixtures across different os
  • fixed incorrect sourcemap sources on windows

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 22, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11717/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11209/

@xtuc
Copy link
Member

xtuc commented Jul 22, 2019

Good idea. For inspiration I have a similar setup here https://github.com/xtuc/webassemblyjs/blob/master/appveyor.yml#L11, with Make, lerna, etc.

@nicolo-ribaudo
Copy link
Member Author

Travis throws that make doesn't exist, but by reading the docs it does 🤔

Also, I'll disable tests on older node versions; I think that it is enought to test only one with windows.

@danez
Copy link
Member

danez commented Jul 27, 2019

I guess we would need #9674 first? I want to start on this soon.

@nicolo-ribaudo
Copy link
Member Author

We can have a windows branch where we merge all these PRs

@JLHwung JLHwung marked this pull request as ready for review September 26, 2019 15:27
@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 26, 2019
.travis.yml Outdated Show resolved Hide resolved
@nicolo-ribaudo
Copy link
Member Author

✔️ (I can't approve my own PR)

@JLHwung
Copy link
Contributor

JLHwung commented Sep 26, 2019

✔️(me neither)

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad we finally got this in!

Curious of how to maintain adding .replace(/\\/g, "/") everywhere but I guess that's exactly what this CI is for when we encounter that issue!

@nicolo-ribaudo nicolo-ribaudo merged commit 127c473 into babel:master Sep 26, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the test-windows branch September 26, 2019 18:58
nicolo-ribaudo added a commit that referenced this pull request Sep 26, 2019
* Add windows to travis

* Update

* Do not use sh file on windows

* Fix whitespace

* Unify command

* ./ doesn't work on windows

* Remove all ./ usages

* Run windows test before others

* fix: normalize filename when generating sources

sources should be URL.

* fix: replace normalized path to cwd

* chore: add nodePlatform task options

* fix: normalize preset-env filename output

* chore: replace normalized path to CWD on win32 platform

* limit transform-react-source to run on linux and darwin

* test: escapeRegExp on testcases

* test: add test for babel --filename on windows

* test: double babel-node/cli test timeout

* chore: workaround windows build does not stop

* chore: remove redundant condition

* refactor: rename `nodePlatform` to `os`
dword-design pushed a commit to dword-design/babel that referenced this pull request Nov 15, 2019
* Add windows to travis

* Update

* Do not use sh file on windows

* Fix whitespace

* Unify command

* ./ doesn't work on windows

* Remove all ./ usages

* Run windows test before others

* fix: normalize filename when generating sources

sources should be URL.

* fix: replace normalized path to cwd

* chore: add nodePlatform task options

* fix: normalize preset-env filename output

* chore: replace normalized path to CWD on win32 platform

* limit transform-react-source to run on linux and darwin

* test: escapeRegExp on testcases

* test: add test for babel --filename on windows

* test: double babel-node/cli test timeout

* chore: workaround windows build does not stop

* chore: remove redundant condition

* refactor: rename `nodePlatform` to `os`
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
os: windows outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
6 participants