Fix _objectSpread2 for real #10188
Merged
Fix _objectSpread2 for real #10188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
nicolo-ribaudo
commented
Jul 9, 2019
| Object.defineProperty( | ||
| target, | ||
| key, | ||
| Object.getOwnPropertyDescriptor(arguments[i], key) | ||
| Object.getOwnPropertyDescriptor(source, key) |
There was a problem hiding this comment.
This was the bug 🪲 🪲🪲🪲🪲🪲
There was a problem hiding this comment.
Right! the forEach on line 433 (ownKeys(source).forEach(function (key) {) is it's own function scope so the arguments[i] usage here is the issue. Solution is to save it as a variable up top and reuse it everywhere.
nicolo-ribaudo
commented
Jul 9, 2019
| @@ -1,6 +1,6 @@ | |||
| const oldGOPDs = Object.getOwnPropertyDescriptors; | |||
| Object.getOwnPropertyDescriptors = null; | |||
|
|
|||
| ({ ...{ a: 1 }, ...{} }); | |||
| ({ ...{ a: 1 }, b: 1, ...{} }); | |||
There was a problem hiding this comment.
This updated test failed before the fix.
hzoo
approved these changes
Jul 9, 2019
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11084/ |
jridgewell
approved these changes
Jul 9, 2019
|
Confirmed that this fixes the problem -- thanks so much @nicolo-ribaudo! |
|
Also confired by @belemaire #10166 (comment) |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't use
argumentsfrom an outer function inside an inner function.I can't use
argumentsfrom an outer function inside an inner function.I can't use
argumentsfrom an outer function inside an inner function.I can't use
argumentsfrom an outer function inside an inner function.(Thanks @hzoo for helping me finding the bug)
@maxmodel or @pwnreza Could you try to update the code in
@babel/helpersinside yournode_moduleslike I did in this PR and confirm that it works?I'll now go hiding myself somewhere and I won't touch an helper for a few months 😆