fix: register injected importDeclaration #10172
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11064/ |
JLHwung
force-pushed
the
fix-export-default-from
branch
from
eac1b1c
to
c301efb
Compare
JLHwung
force-pushed
the
fix-export-default-from
branch
from
c301efb
to
c092c1e
Compare
JLHwung
changed the title
nicolo-ribaudo
added
PR: Bug Fix 🐛
| @@ -35,6 +35,11 @@ export default declare(api => { | |||
|
|
|||
| path.replaceWithMultiple(nodes); | |||
| }, | |||
| ImportDefaultSpecifier(path) { | |||
| if (!path.scope.hasOwnBinding(path.node.local.name)) { | |||
| path.scope.registerDeclaration(path.parentPath); | |||
There was a problem hiding this comment.
I would prefer to do this as soon as the import declaration is created, in the ExportNamedDeclaration visitor. This makes it clearer why we are doing it, and it prevents other plugin from running between the creating the declaration and registering it.
path.replaceWithMultiple(nodes); returns an array containing the new inserted paths: the first one should be the import declaration, and you can get it's default specifier.
There was a problem hiding this comment.
path.replaceWithMultiple(nodes)returns an array containing the new inserted paths.
Yes it is. It seems that @types/babel__traverse declares out-of-dated signature here.
lock
bot
added
the
outdated
When
transform-typescriptcombines withproposal-export-default-from, theexport { _foo as foo };will be erased as it seems that_foois not defined in its own scope. This PR register the injected importDeclaration so that it can work well with elideImports fromtransform-typescript.Note that #7592 uses
scope.crawl()to manually sync nodes to AST. Ascrawlwill incur great performance overkill, our approach check the injected import specifier only and register when necessary.