Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigInt type for Flow #10091

Merged
merged 4 commits into from Jul 3, 2019
Merged

Conversation

tanhauhau
Copy link
Member

Building on top of #10084,
I've fixed a few several test cases for run_babel_parser_flow_tests and removed them from the whitelist.

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 13, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11015/

@tanhauhau tanhauhau changed the title wip: fix flow tests Fix flow tests Jun 15, 2019
@tanhauhau
Copy link
Member Author

hmm.. running out of memory

@tanhauhau tanhauhau changed the title Fix flow tests BigInt type for Flow Jun 23, 2019
);
}

this.unexpected(null, `Unexpected token, expected "number"`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.unexpected(null, `Unexpected token, expected "number"`);
this.unexpected(null, `Unexpected token, expected "number" or "bigint"`);

@nicolo-ribaudo nicolo-ribaudo added area: flow pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: BigInt labels Jun 27, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit f588e4e into babel:master Jul 3, 2019
@tanhauhau tanhauhau deleted the tanhauhau/fix-flow-tests branch July 3, 2019 15:04
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: BigInt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants