Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preset-env dependencies and fix fixtures #10002

Merged
merged 2 commits into from May 21, 2019
Merged

Update preset-env dependencies and fix fixtures #10002

merged 2 commits into from May 21, 2019

Conversation

danez
Copy link
Member

@danez danez commented May 20, 2019

Q                       A
Fixed Issues? n
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@danez danez added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: preset-env labels May 20, 2019
@danez danez requested a review from zloirock May 20, 2019 22:47
@@ -161,6 +162,7 @@ Using polyfills with `entry` option:
es.string.includes { "ie":"10" }
es.string.iterator { "ie":"10" }
es.string.match { "ie":"10" }
es.string.match-all { "chrome":"54", "ie":"10", "node":"6.10" }
es.string.pad-end { "chrome":"54", "ie":"10", "node":"6.10" }
es.string.pad-start { "chrome":"54", "ie":"10", "node":"6.10" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only fixture that actually changes something. All the other ones just moved the import from a to b.

@babel-bot
Copy link
Collaborator

babel-bot commented May 20, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10821/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10820/

@zloirock
Copy link
Member

Seems it would be better also update core-js-compat dependency.

@danez
Copy link
Member Author

danez commented May 20, 2019

Seems it would be better also update core-js-compat dependency.

It is using the latest version of core-js-compat

@zloirock
Copy link
Member

I mean bump preset-env core-js-compat dependency in package.json to ^3.1.1.

@danez danez changed the title Fix fixtures after core-js update Update preset-env dependencies and fix fixtures May 20, 2019
@danez danez added PR: Bug Fix 🐛 A type of pull request used for our changelog categories and removed PR: Internal 🏠 A type of pull request used for our changelog categories labels May 20, 2019
@buildsize
Copy link

buildsize bot commented May 20, 2019

File name Previous Size New Size Change
babel-preset-env.js 2.24 MB 2.27 MB 33.53 KB (1%)
babel-preset-env.min.js 1.29 MB 1.31 MB 17.54 KB (1%)
babel.js 2.81 MB 2.81 MB 9 bytes (0%)
babel.min.js 1.56 MB 1.56 MB 9 bytes (0%)

@danez danez merged commit 0430a48 into babel:master May 21, 2019
@danez danez deleted the fix-test branch May 21, 2019 06:27
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants