allow directives and other comments before flow pragma #9891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganfsmyth
reviewed
Apr 24, 2019
| @@ -95,12 +95,26 @@ export default (superClass: Class<Parser>): Class<Parser> => | |||
| return this.getPluginOption("flow", "all") || this.flowPragma === "flow"; | |||
| } | |||
|
|
|||
| finishNodeAt<T: N.Node>( | |||
There was a problem hiding this comment.
Would we be able to override finishToken to get the behavior you're looking for of bailing after a semi/string token?
There was a problem hiding this comment.
hmm.. interesting, let me try that. But which means it would have to handle whitespace, slash tokens for comments right?
tanhauhau
force-pushed
the
tanlh/fix/flow-pragma-2
branch
from
aa3982b
to
2f2cc10
Compare
|
Interesting the pipeline failed for unknown reasons |
|
It's fixed by #9906 |
nicolo-ribaudo
approved these changes
Apr 26, 2019
|
Thanks! |
existentialism
approved these changes
Apr 26, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handles 3 cases correctly:
// @flowflow pragma comment// @flowflow pragma comment// @flowflow pragma content is the first comment, but appear in the middle of the codeit is slightly different than the flow logic I described in #9240 (comment), but I think it's fair enough given the differences in the lexer logic between flow and babel, and it's definitely better than the current logic