New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove core-js dependency from @babel/register #9847
Remove core-js dependency from @babel/register #9847
Conversation
This module doesn't use core-js at all.
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10681/ |
While this could be removed, I am a bit worried that it will break users using cc @babel/babel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyone relying on this being implicitly present already has a bug; this error will surface their broken package.json most efficiently, at build time.
Perhaps we should move the core-js dep to preset-env, then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Actually, |
ok, fair point on that. still tho, theoretically any test of any kind on a babelified file would expose it? |
The dependency
core-js
is not actually used by@babel/register
so this PR removes it.