Fix super Method Calls in Class Private Methods
#9704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10522/ |
jridgewell
approved these changes
Mar 19, 2019
| this.isStatic = | ||
| path.isClassMethod({ static: true }) || path.isObjectMethod(); | ||
| this.isStatic = path.isObjectMethod() || path.node.static; | ||
| this.isPrivateMethod = path.isPrivate() && path.isMethod(); |
There was a problem hiding this comment.
Nit: I would just add this as a new case to isStatic.
There was a problem hiding this comment.
I kept them separate because rolling isPrivateMethod into isStatic will cause an issue with the loose handler. If the path is an instance private method, this condition becomes truthy, and this output is instead transformed to:
var _privateMethod2 = function _privateMethod2() {
return Base.superMethod.call(this);
};
danez
added
PR: Bug Fix 🐛
nicolo-ribaudo
approved these changes
Mar 19, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the use of super method calls in class private methods. See #9580 for more info re: behavior of the bug.