Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typescript parsing typed object shorthand methods #8677

Merged
merged 1 commit into from Sep 14, 2018
Merged

Fix typescript parsing typed object shorthand methods #8677

merged 1 commit into from Sep 14, 2018

Conversation

existentialism
Copy link
Member

Q                       A
Fixed Issues? Fixes #7415
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@existentialism existentialism added pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Sep 11, 2018
@existentialism existentialism changed the title Fix typescript parsing typeed object shorthand methods Fix typescript parsing typed object shorthand methods Sep 11, 2018
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9089/

hzoo
hzoo approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 😄

@existentialism existentialism merged commit 380f2a0 into master Sep 14, 2018
@existentialism existentialism deleted the issue7415 branch September 14, 2018 15:21
This was referenced Sep 18, 2018
Merged
Merged
Open
Open
@dependencies dependencies bot mentioned this pull request Oct 1, 2018
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzoo hzoo hzoo approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[typescript] "Error: TODO" when parsing generic object shorthand methods
4 participants
@existentialism @babel-bot @hzoo @nicolo-ribaudo