Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagates the extensions overrides provided by CLI during files walk #8668

Merged

Conversation

katrotz
Copy link
Contributor

@katrotz katrotz commented Sep 10, 2018

Q                       A
Fixed Issues? Fixes #7620
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? No
Documentation PR Link
Any Dependency Changes? No
License MIT

Takes into account the CLI --extensions argument when looking up the source files.
Eg. When used with preset-typescript and --extensions .ts as argument, will include all .ts files found in the source directory.

@babel-bot
Copy link
Collaborator

babel-bot commented Sep 10, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9111/

@loganfsmyth
Copy link
Member

Would you be interested in adding tests? If not, that's totally fine though. It should mean adding one example fixture along the lines of the one in https://github.com/babel/babel/tree/master/packages/babel-cli/test/fixtures/babel/filename%20--out-file

@katrotz
Copy link
Contributor Author

katrotz commented Sep 11, 2018

@loganfsmyth Absolutely, will take care of the tests today.

@katrotz
Copy link
Contributor Author

katrotz commented Sep 12, 2018

@loganfsmyth

@loganfsmyth Absolutely, will take care of the tests today.

done

@loganfsmyth loganfsmyth merged commit 2bf8dde into babel:master Nov 30, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI --extensions ignored when traversing subdirectories
3 participants