Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'decoratorsBeforeExport' can't be used with legacy decorators. #8569

Closed
mspoerer opened this issue Aug 28, 2018 · 3 comments
Closed

'decoratorsBeforeExport' can't be used with legacy decorators. #8569

mspoerer opened this issue Aug 28, 2018 · 3 comments
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@mspoerer
Copy link

mspoerer commented Aug 28, 2018

Bug Report

Current Behavior
As the documentation describes, the @babel/plugin-proposal-decorators can be configured through the parameters: decoratorsBeforeExport and legacy.
Somehow the combination of decoratorsBeforeExport: true & legacy: true throws an error.

Line of Code:

"'decoratorsBeforeExport' can't be used with legacy decorators.",

@babel-bot
Copy link
Collaborator

Hey @mspoerer! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

@mspoerer
Copy link
Author

mspoerer commented Aug 28, 2018

It seems that the documentation is wrong. The default value of the parameter decoratorsBeforeExport is true and not false.

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Aug 28, 2018

The documentation is wrong because it doesn't have a default value. It can only be used if you are using legacy: false (so it can never be used until we support legacy: false).

This is a duplicate of #8562. Do you want to update the docs?

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

No branches or pull requests

3 participants