Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identifier location range include type annotation is inconvenient #6707

Closed
babel-bot opened this issue Dec 28, 2016 · 1 comment
Closed

identifier location range include type annotation is inconvenient #6707

babel-bot opened this issue Dec 28, 2016 · 1 comment
Labels
imported outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser

Comments

@babel-bot
Copy link
Collaborator

Issue originally reported by @hax in babel/babylon#268

Currently identifier with flow type annotation will have location/range include the type annotation.

Such behavior is strange and very inconvenient for the tools.

For example, hax/js-refactor@d4f5f36 hacked for it, but it's still not accurate and it seems no easy way to get the accurate range without lookup token list.
@babel-bot babel-bot mentioned this issue Nov 1, 2017
Closed
@nicolo-ribaudo
Copy link
Member

Closing in favor of #9545

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
imported outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolo-ribaudo @babel-bot