Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data issues #6432

Closed
hzoo opened this issue Oct 5, 2017 · 7 comments
Closed

Data issues #6432

hzoo opened this issue Oct 5, 2017 · 7 comments
Labels
help wanted outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env

Comments

@hzoo
Copy link
Member

hzoo commented Oct 5, 2017


Migrated from babel/babel-preset-env#7
Originally created by @hzoo on Tue, 06 Sep 2016 03:50:00 GMT


Data can be wrong in https://github.com/babel/babel-preset-env/blob/master/src/plugins.js.

We're using https://kangax.github.io/compat-table/es6/ now

screen shot 2016-10-08 at 11 13 43 am

There is also the issue of bugs in babel, bugs in the implementation, incomplete implementations (it supports the basic test of a feature but not everything), etc. This will require a lot of work to figure out but shouldn't be too bad with testing/attention to detail.

Can also use https://github.com/sdkennedy/babel-preset-target

@hzoo
Copy link
Member Author

hzoo commented Oct 5, 2017


Migrated from babel/babel-preset-env#7 (comment)
Originally created by @DZuz14 on Fri, 07 Oct 2016 02:43:45 GMT


Any stuff a junior dev can work on? Will gladly help out with anything I can.

@hzoo
Copy link
Member Author

hzoo commented Oct 5, 2017


Migrated from babel/babel-preset-env#7 (comment)
Originally created by @hzoo on Thu, 06 Oct 2016 22:15:03 GMT


we'll need to make some PRs to compat-table as we go when we find issues/missing stuff

@hzoo
Copy link
Member Author

hzoo commented Oct 5, 2017


Migrated from babel/babel-preset-env#7 (comment)
Originally created by @hzoo on Thu, 06 Oct 2016 18:24:16 GMT


We should figure out granularity

  • some browsers implement under a flag: (compat-table has flag, strict, etc) - what are these?
  • maybe the browser implements most of the feature (say 12/13) which covers most use cases etc.

@hzoo
Copy link
Member Author

hzoo commented Oct 5, 2017


Migrated from babel/babel-preset-env#7 (comment)
Originally created by @hzoo on Sat, 15 Oct 2016 13:57:56 GMT


We're using compat-table already so we can close this. The issue is just that the data might be not up or date or the logic incorrect but that's an ongoing effort

@hzoo
Copy link
Member Author

hzoo commented Oct 5, 2017


Migrated from babel/babel-preset-env#7 (comment)
Originally created by @hzoo on Fri, 07 Oct 2016 02:45:44 GMT


One thing that we want to do (continually) is check that data/plugins.json is actually correct/accurate to both what's actually true (testing in browsers/node) as well as correct to kangax.github.io/compat-table/es6/ (although annoying)

@hzoo
Copy link
Member Author

hzoo commented Oct 5, 2017


Migrated from babel/babel-preset-env#7 (comment)
Originally created by @fson on Sun, 18 Sep 2016 20:33:42 GMT


I took a first stab at generating the data from ES compatibility table in #8.

@hzoo
Copy link
Member Author

hzoo commented Oct 5, 2017


Migrated from babel/babel-preset-env#7 (comment)
Originally created by @chicoxyzzy on Sat, 24 Sep 2016 11:12:08 GMT


Hey! Compatibility table collaborator here! I just want you to know I will be working on moving raw data to a distinct npm package soon.

@hzoo hzoo closed this as completed Oct 5, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env
Projects
None yet
Development

No branches or pull requests

1 participant