Flow opaque type 6.x backport #6081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtuc
added
6.x: backport
area: flow
PR: Spec Compliance 👓
|
Looking forward to this! |
|
@hzoo changed target to master and bumped babylon in babel-core, babel-generator, babel-traverse, and babel-types to 6.18.0 |
|
@hzoo: the build is broken for the same reason it was broken in the pr to 7.0. I'm going to backport @existentialism's fix (#6031) and put up another PR to master |
|
cool, thanks. it's fine locally? |
|
problem repros locally, but with changes from #6031 everything is fine |
This was referenced Mar 14, 2018
Closed
Closed
Closed
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5990. Depends on babel/babylon#644
I added all the same tests (with some slight changes) to babel-generator, babel-plugin-transform-flow-strip-types, and babel-plugin-transform-flow-comments.
Note: When using the current state of 6.x on both babel and babylon, there were two tests errors:
bin/babel-node v8Flag-dashed-with-param and bin/babel-node v8Flag-underscored-with-param
This diff will also have those errors