Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Specify node version in options.json #5752

Closed
peey opened this issue May 19, 2017 · 2 comments
Closed

Feature Request: Specify node version in options.json #5752

peey opened this issue May 19, 2017 · 2 comments
Labels
Has PR outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@peey
Copy link
Contributor

peey commented May 19, 2017

Feature Request

Currently, the code on CI runs on multiple node versions. Some tests may not work on lower node versions. For such tests we need to check for process.version in the test and optionally wrap the code in an eval (to avoid SyntaxErrors) (example)

There could be a semver-style key in options.json to specify which node versions a particular test is meant to be run on.

@babel-bot
Copy link
Collaborator

Hey @peey! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

@hzoo
Copy link
Member

hzoo commented May 25, 2017

#5765: minNodeVersion, thanks @buunguyen!

@hzoo hzoo closed this as completed May 25, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Has PR outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

No branches or pull requests

3 participants