New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add charset so tests work with convert-source-map@>1.4 #5302
Conversation
cc @thlorenz as FYI |
Hey @loganfsmyth! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. |
Codecov Report
@@ Coverage Diff @@
## master #5302 +/- ##
=========================================
Coverage ? 89.44%
=========================================
Files ? 204
Lines ? 9956
Branches ? 2692
=========================================
Hits ? 8905
Misses ? 1051
Partials ? 0 Continue to review full report at Codecov.
|
Definitely on the fence as to whether the constitutes breaking, not because I care that our test broke, but just because we have no way of knowing if downstream systems actually properly parse data URLs. For now my vote is we fix the tests and hope for the best, and if we get reports of sourcemap issues, we can always pin |
85bb6af
to
e5377d2
Compare
The charset value is actually a fix, shouldn't break anything which is why we published as a minor. If you run into any problems please LMK. @Delagen actually provided that change, so he may be able to provide more background.
I wouldn't recommend that as then you'll basically avoid the fix. |
Yeah I'm not going to worry about it unless we actually hear of issues. I totally agree with you, and it's always hard to decide what constitutes "breaking" when a bugfix might cause issues for people who weren't parsing things properly to begin with. |
* Add new flow preset (#5288) * Fix PathHoister hoisting JSX member expressions on "this". (#5143) The PathHoister ignored member references on "this", causing it to potentially hoist an expression above its function scope. This patch tells the hoister to watch for "this", and if seen, mark the nearest non-arrow function scope as the upper limit for hoistng. This fixes #4397 and is an alternative to #4787. * Fix PathHoister hoisting before bindings. (#5153) Fixes #5149 and enables a few additional safe hoists. * Fix linting error * feature: Support pure expressions in transform-react-constant-elements (#4812) * Fix loose for-of with label (#5298) * Rewrite Hub as interface #5047 (#5050) * Rewrite Hub as interface #5047 * Update index.js * Avoid adding unnecessary closure for block scoping (#5246) When you write ``` for (const x of l) { setTimeout(() => x); } ``` we need to add a closure because the variable is meant to be block-scoped and recreated each time the block runs. We do this. However, we also add the closure when no loop is present. This isn't necessary, because if no loop is present then each piece of code runs at most once. I changed the transform to only add a closure if a variable is referenced from within a loop. * Add greenkeeperio-bot to mention-bot blacklist (#5301) [skip ci] * Upgrade lerna to current beta. (#5300) * Revert "Upgrade lerna to current beta." (#5303) * Add charset so tests work with convert-source-map@>1.4 (#5302) * Add CHANGELOG for 6.23.0 [skip ci] (#5304) * Update babel-types README from script. * v6.23.0 * Revert change that lerna force-committed. * Revert "Rewrite Hub as interface #5047" (#5306) * v6.23.1 * Revert lerna again
See conversation in babel/babel#5302 for details.
Fix a test broken by the introduction of a
charset
value inconvert-source-map@1.4
. See thlorenz/convert-source-map@4b8aaf9