[CI] Test babel builds on Windows #13796
Labels
i: enhancement
i: needs triage
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
馃捇
What problem are you trying to solve?
When attempting to contribute to Babel for the first time, I tried to setup a development environment on Windows, but the build scripts had a bug specific to Windows which forced me to first debug and fix something other than what I tried to solve (it wasn't too difficult, but still).
This bug was introduced in #13423 and closed in #13795, so for nearly 4 months it went unnoticed that Windows users had a problem working on the project. I think it's worth making sure that Windows builds work, as the build scripts are not trivial and may fail (Makefile/Gulpfile).
Describe the solution you'd like
I suggest that a check that builds babel on Windows be added to the CI.
I think that the existing check that runs tests on Windows should still use the artifacts from the Linux build, since those are probably what gets shipped to users, and it makes more sense to run tests on the production code. I don't think there's a need to also run the tests on the Windows build. Maybe it should check the artifacts are identical, not sure if they should be.
I can try to submit a PR, but I don't have a way to test that the CI works.
Describe alternatives you've considered
I'm not sure if GitHub's CI costs money, so if adding another check raises the price it might be okay to leave it as-is, since it seems mostly the core team works on Babel and they probably don't work on Windows. The check can also be added to the existing check that runs the tests on Windows.
Documentation, Adoption, Migration Strategy
No response
The text was updated successfully, but these errors were encountered: