Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Test babel builds on Windows #13796

Closed
1 task
NotWearingPants opened this issue Sep 26, 2021 · 1 comment 路 Fixed by #14463
Closed
1 task

[CI] Test babel builds on Windows #13796

NotWearingPants opened this issue Sep 26, 2021 · 1 comment 路 Fixed by #14463
Labels
i: enhancement i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@NotWearingPants
Copy link
Contributor

馃捇

  • Would you like to work on this feature?

What problem are you trying to solve?

When attempting to contribute to Babel for the first time, I tried to setup a development environment on Windows, but the build scripts had a bug specific to Windows which forced me to first debug and fix something other than what I tried to solve (it wasn't too difficult, but still).

This bug was introduced in #13423 and closed in #13795, so for nearly 4 months it went unnoticed that Windows users had a problem working on the project. I think it's worth making sure that Windows builds work, as the build scripts are not trivial and may fail (Makefile/Gulpfile).

Describe the solution you'd like

I suggest that a check that builds babel on Windows be added to the CI.

I think that the existing check that runs tests on Windows should still use the artifacts from the Linux build, since those are probably what gets shipped to users, and it makes more sense to run tests on the production code. I don't think there's a need to also run the tests on the Windows build. Maybe it should check the artifacts are identical, not sure if they should be.

I can try to submit a PR, but I don't have a way to test that the CI works.

Describe alternatives you've considered

I'm not sure if GitHub's CI costs money, so if adding another check raises the price it might be okay to leave it as-is, since it seems mostly the core team works on Babel and they probably don't work on Windows. The check can also be added to the existing check that runs the tests on Windows.

Documentation, Adoption, Migration Strategy

No response

@babel-bot
Copy link
Collaborator

Hey @NotWearingPants! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: enhancement i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants