Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel parser typescript should throw when declare is applied to accessors #13126

Closed
1 task
JLHwung opened this issue Apr 9, 2021 · 2 comments · Fixed by #13143
Closed
1 task

Babel parser typescript should throw when declare is applied to accessors #13126

JLHwung opened this issue Apr 9, 2021 · 2 comments · Fixed by #13143
Assignees
Labels
area: typescript i: bug outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser

Comments

@JLHwung
Copy link
Contributor

JLHwung commented Apr 9, 2021

Bug Report

  • I would like to work on a fix!

Current behavior

Parsed successfully.

Input Code

class C99 {
  declare get baz(): C99
  declare set baz(v)
}

Expected behavior

Babel parser should throw class accessors should not have "declare" modifier, like we did for class methods.

Babel Configuration (babel.config.js, .babelrc, package.json#babel, cli command, .eslintrc)
REPL

Possible Solution

Additional context

Found this issue when reviewing #13089.

@babel-bot
Copy link
Collaborator

Hey @JLHwung! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@fedeci fedeci self-assigned this Apr 12, 2021
@fedeci
Copy link
Member

fedeci commented Apr 12, 2021

I can handle this!

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript i: bug outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants