Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot transpile yield/await spread for Firefox 47 #12690

Closed
boris-petrov opened this issue Jan 25, 2021 · 3 comments
Closed

Cannot transpile yield/await spread for Firefox 47 #12690

boris-petrov opened this issue Jan 25, 2021 · 3 comments
Labels
area: upstream i: bug outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@boris-petrov
Copy link

Bug Report

Current behavior

import Component from '@glimmer/component';
import intersection from 'lodash/intersection';

export default class FooComponent extends Component {
  async foo() {
    intersection(...(await Promise.all([])));
  }
}

Expected behavior
Code to be transpiled correctly.

Currently Babel blows up with:

Expected type "Expression" with option undefined, but instead got "SpreadElement".

Using firefox 35 for targets works. As does firefox 53 and above.

@babel-bot
Copy link
Collaborator

Hey @boris-petrov! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jan 25, 2021

Minimal reproduction:

function *foo() {
  intersection(...yield);
}

EDIT: This is probably facebook/regenerator#397. A fix would probably be similar to facebook/regenerator#385, if anyone wants to help.

@boris-petrov boris-petrov changed the title Cannot transpile for Firefox 47 Cannot transpile yield/await spread for Firefox 47 Jan 26, 2021
@nicolo-ribaudo
Copy link
Member

Closing as tracked at facebook/regenerator#397

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: upstream i: bug outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

No branches or pull requests

4 participants