Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@babel/core and babel-preset-current-node-syntax contain files with date older than 1980 #12501

Closed
BenoitAverty opened this issue Dec 14, 2020 · 5 comments · Fixed by nicolo-ribaudo/babel-preset-current-node-syntax#8
Labels
i: bug i: third party The report is a problem of third party outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@BenoitAverty
Copy link

Bug Report

Current behavior

Babel contain some very old files.

To reproduce, install @babel/core and babel-preset-current-node-syntax on a fresh empty npm project, then run

find ! -newermt 1981-01-01

This gives the list of files older than January the first, 1980.

This is a problem when zipping the files because ZIP does not support timestamps that old. It happens, for example, when deploying an app to AWS

This seems to change based on the version of babel, for example, the latest babel-core has files from 1984 wheras the version used by @mdx-js has files from 1970.

Lastest babel-preset-current-node-syntax has some from before 1980.

Possible Solution

As a workaround, uses can run
find ! -newermt 1981-01-01 -exec touch {} \
to fix the date. But it requires having diagnosed the problem.

@babel-bot
Copy link
Collaborator

Hey @BenoitAverty! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@nicolo-ribaudo
Copy link
Member

Which version of those packages are you using? It should have already be fixed in both of them 🤔

@BenoitAverty
Copy link
Author

Hey !
Here is the dependencies in the package.json :

"dependencies": {
    "@babel/core": "^7.12.10",
    "babel-preset-current-node-syntax": "^1.0.0"
  }

freshly installed with npm install.

@nicolo-ribaudo
Copy link
Member

This could be a regression caused by #12453

@JLHwung
Copy link
Contributor

JLHwung commented Dec 14, 2020

The issue should be filed to https://github.com/nicolo-ribaudo/babel-preset-current-node-syntax

@babel/core 7.12.10 is not affected.

$ curl -s `npm view @babel/core dist.tarball` --output - | tar -tvf -
-rw-r--r--  0 0      0        1106 22 Jun  1984 package/LICENSE
-rw-r--r--  0 0      0         404 22 Jun  1984 package/README.md
(...)
$ curl -s `npm view babel-preset-current-node-syntax dist.tarball` --output - | tar -tvf -

-rw-r--r--  0 0      0        1095 31 Dec  1979 package/LICENSE
-rw-r--r--  0 0      0         794 31 Dec  1979 package/README.md
-rw-r--r--  0 0      0        1422 31 Dec  1979 package/package.json
-rw-r--r--  0 0      0        1865 31 Dec  1979 package/src/index.js

@JLHwung JLHwung added i: third party The report is a problem of third party and removed i: regression labels Dec 14, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: bug i: third party The report is a problem of third party outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants