Parser fail on errorRecovery mode

[fisker]

Bug Report

• I would like to work on a fix!

Current behavior

node -p "require('@babel/parser').parse('const a = {set name(){}}', {errorRecovery: true})"
    if (method.kind === "set" && method.params[method.params.length - 1].type === "RestElement") {
                                                                         ^

TypeError: Cannot read property 'type' of undefined
    at Parser.checkGetterSetterParams (@babel\parser\lib\index.js:10792:74)
    at Parser.parseObjectMethod (@babel\parser\lib\index.js:10800:12)
    at Parser.parseObjPropValue (@babel\parser\lib\index.js:10841:23)
    at Parser.parsePropertyDefinition (@babel\parser\lib\index.js:10772:10)
    at Parser.parseObjectLike (@babel\parser\lib\index.js:10664:25)
    at Parser.parseExprAtom (@babel\parser\lib\index.js:10198:23)
    at Parser.parseExprSubscripts (@babel\parser\lib\index.js:9844:23)
    at Parser.parseUpdate (@babel\parser\lib\index.js:9824:21)
    at Parser.parseMaybeUnary (@babel\parser\lib\index.js:9813:17)
    at Parser.parseExprOps (@babel\parser\lib\index.js:9683:23)

With errorRecovery: true parser didn't throw syntax error

Input Code

const a = {set name(){}}

Expected behavior

Should throw a SyntaxError or continue parse.

Babel Configuration (babel.config.js, .babelrc, package.json#babel, cli command, .eslintrc)

N/A

Environment

- Babel version(s): 7.11.5
- Node/npm version: Node.js 12
- OS: Windows 10
- Monorepo: no
- How you are using Babel: parser api

Possible Solution

N/A

Additional context

Context: prettier/prettier#9226

[babel-bot]

Hey @fisker! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

[nicolo-ribaudo]

Thanks for the report! Probably using ?. there would be enough.

[fisker]

This one seems simple, I'm tring to fix it.