Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention babel/rfcs in the "New feature" issue template #11592

Merged
merged 2 commits into from May 26, 2020

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
License MIT

@nicolo-ribaudo nicolo-ribaudo requested a review from hzoo May 21, 2020 17:51
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b09901e:

Sandbox Source
dry-firefly-sikm4 Configuration
strange-night-6el1m Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented May 21, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/22545/

@@ -7,6 +7,10 @@ assignees: ''

---

<!---
Copy link
Member

@hzoo hzoo May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to change the ordering, but we can also point to the repo here in the template: https://github.com/babel/babel/blob/master/.github/ISSUE_TEMPLATE/config.yml as an external link, depending on what they see

image

maybe change the npm error one into a link to somewhere too? since we aren't asking them to make an issue anyway

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, did not know this was a thing!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍 Maybe we could put the message in a gist and link it?

@hzoo hzoo merged commit 2d27cf8 into master May 26, 2020
@hzoo hzoo deleted the nicolo-ribaudo-patch-1 branch May 26, 2020 16:47
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 26, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants