Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix build-babel exclude in gulpfile #11293

Merged
merged 1 commit into from Mar 21, 2020
Merged

chore: fix build-babel exclude in gulpfile #11293

merged 1 commit into from Mar 21, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 20, 2020

Q                       A
Fixed Issues? the published babel-parser artifacts include unrolled up files: https://unpkg.com/browse/@babel/parser@7.7.5/lib/
Tests Added + Pass? Yes
License MIT

This PR fixes an artifacts regression introduced at #10779, where the exclude schema is changed from string to an object, but is forgotten to sync with buildBabel.

Testing:
Run make prepublish-build && ll packages/babel-parser/lib on my local env:

total 712
-rw-r--r--  1 jh  staff  363469 20 Mar 14:57 index.js

@JLHwung JLHwung added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: parser labels Mar 20, 2020
existentialism
existentialism approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good find

@nicolo-ribaudo nicolo-ribaudo merged commit 5b2c1f3 into babel:master Mar 21, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the fix-duplicate-babel-parser-artifacts branch March 21, 2020 18:39
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JLHwung @existentialism @nicolo-ribaudo