New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade semver for compatibility with Node 6 #10991
Conversation
nicolo-ribaudo
commented
Jan 12, 2020
Q | A |
---|---|
Fixed Issues? | Fixes #10990 |
Patch: Bug Fix? | Yes |
Major: Breaking Change? | |
Minor: New Feature? | |
Tests Added + Pass? | Yes |
Documentation PR Link | |
Any Dependency Changes? | |
License | MIT |
@nicolo-ribaudo semver v6 also works down to node 0.8; i think that's the lowest you really need to go (and compared to v5, has better handling of prereleases) |
Pinned |
I used v5 because we are already using it in other Babel packages. |
when this version will be published? |
It has already been published a few minutes after this PR has been merged. Only the updated packages have been released. |
our build is failing (node 6), and I think it relates to this fix, getting |
That's an npm bug on windows, i believe (possibly a new, registry-caused one) |
this is happening both on jenkins (linux) and reproduced locally (mac os) |
They have been published: https://www.npmjs.com/package/@babel/highlight
|
ok, thanks |