Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unresolvable runtime helper modules after upgrading to v7.7.5 #10832

Closed
rwjblue opened this issue Dec 6, 2019 · 1 comment · Fixed by #10835
Closed

Unresolvable runtime helper modules after upgrading to v7.7.5 #10832

rwjblue opened this issue Dec 6, 2019 · 1 comment · Fixed by #10835
Assignees
Labels
i: bug i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue Priority: High

Comments

@rwjblue
Copy link
Member

rwjblue commented Dec 6, 2019

Bug Report

#10549 introduced a bit of breakage to consumers of ember-cli-babel.

When using @babel/plugin-transform-modules-amd to transpile the runtime helpers (from @babel/runtime/helpers/esm) into AMD modules, the resulting define statement's do not include the .js extension. However, when using @babel/plugin-transform-runtime@7.7.5 (which includes #10549) along with useESModules: true the import statements will include .js which results in "module not found" errors.

@rwjblue
Copy link
Member Author

rwjblue commented Dec 6, 2019

I'm happy to work on changes to ember-cli-babel to accommodate this change, but wanted to open an issue here to discuss (in case other communities are affected as well).

@JLHwung JLHwung self-assigned this Dec 6, 2019
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 8, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: bug i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue Priority: High
Projects
None yet
3 participants