New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune makefile scripts #10781
Tune makefile scripts #10781
Conversation
jestArgs="--coverage" | ||
|
||
if [ -n "$CI" ]; then | ||
jestArgs="${jestArgs} --maxWorkers=4 --ci" | ||
fi | ||
|
||
node_modules/.bin/jest $jestArgs | ||
$node node_modules/.bin/jest $jestArgs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We leave jest
to be relative path as we plan to unplug jest on yarn 2 so that it can work with --inspect-brk
.
a5cf4c0
to
f1b4c3c
Compare
c734f18
to
46b831e
Compare
@@ -14,6 +14,9 @@ EMPTY := | |||
SPACE := $(EMPTY) $(EMPTY) | |||
COMMA_SEPARATED_SOURCES = $(subst $(SPACE),$(COMMA),$(SOURCES)) | |||
|
|||
YARN := yarn --silent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will suppress the yarn foo v1.2.3
header printed by yarn. I think it is okay to use $(YARN)
when we use it to invoke another node binaries, e.g. eslint/prettier.
In this PR we wrap
node
call into ayarn
call so it can be future-proof on upcoming yarn 2 upgrade.