Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] Parse calls with type args in optional chains #10631

Merged
merged 2 commits into from Nov 4, 2019
Merged

[TS] Parse calls with type args in optional chains #10631

merged 2 commits into from Nov 4, 2019

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #10626
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser area: typescript labels Nov 2, 2019
@JLHwung
Copy link
Contributor

JLHwung commented Nov 3, 2019

@nicolo-ribaudo Did you commit the test output?

@nicolo-ribaudo
Copy link
Member Author

Ops, I'm adding it now

@buildsize
Copy link

buildsize bot commented Nov 3, 2019

File name Previous Size New Size Change
babel-preset-env.js 2.77 MB 2.77 MB -605 bytes (0%)
babel-preset-env.min.js 1.67 MB 1.67 MB -341 bytes (0%)
babel.js 2.95 MB 2.95 MB -605 bytes (0%)
babel.min.js 1.63 MB 1.63 MB -341 bytes (0%)
test262.tap 4.84 MB [deleted]

@JLHwung JLHwung merged commit d023e10 into babel:master Nov 4, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the ts-optional-chain-call-params branch November 4, 2019 20:47
@snyk-bot snyk-bot mentioned this pull request Nov 14, 2019
Merged
This was referenced Nov 28, 2019
Open
Open
This was referenced Dec 5, 2019
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Open
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 3, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript generic function and optional chaining drops fn context
3 participants
@nicolo-ribaudo @JLHwung @existentialism